fix: RadioGroup should not validate on form reset #8212
Merged
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
approved these changes
May 19, 2025
| @@ -186,7 +186,7 @@ export const Radio = /*#__PURE__*/ (forwardRef as forwardRefType)(function Radio | |||
| } = props; | |||
| [props, ref] = useContextProps(otherProps, ref, RadioContext); | |||
| let state = React.useContext(RadioGroupStateContext)!; | |||
| let inputRef = useObjectRef(mergeRefs(userProvidedInputRef, props.inputRef !== undefined ? props.inputRef : null)); | |||
| let inputRef = useObjectRef(useMemo(() => mergeRefs(userProvidedInputRef, props.inputRef !== undefined ? props.inputRef : null), [userProvidedInputRef, props.inputRef])); | |||
There was a problem hiding this comment.
I think this is correct, we usually useMemo with mergeRefs and useObjectRef, it looks like this one was missed
yihuiliao
approved these changes
May 19, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 19, 2025
Co-authored-by: Robert Snow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8134
Since the ref is not a stable reference, the previous `onReset` gets unmounted during a React discrete update.react-spectrum/packages/@react-aria/form/src/useFormValidation.ts
Lines 91 to 93 in ef27de0
To solve this, we have to make sure that the `inputRef` is always a stable reference.I can't clearly explain what happened, but here's a similar case.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: